search

KeyviDev / keyvi

Keyvi - the key value index. It is an in-memory FST-based data structure highly optimized for size and lookup performance.
Apache License 2.0
239 stars 42 forks source link

Coverage reporting broken for newer versions of gcc(gcov) #179

Open hendrikmuhs opened 3 years ago

hendrikmuhs commented 3 years ago

After bumping the ubuntu image to 20.04 (to fix rust builds) the coverage report broke and e.g. reported wrong line counts and as a result of that wrong coverage. The image for creating coverage reports has been set back to 16.04.

The problem turned out to be a problem with the extended format of gcov introduced in gcc 8, it reports coverage for instances of templates. The parser from cpp-coveralls produces wrong results as result of that, I created an upstream fix: https://github.com/eddyxu/cpp-coveralls/pull/157.

narekgharibyan commented 3 years ago

Hah, great find @hendrikmuhs!

Hope they will accept the PR soon, as the repo didn't seem to be actively maintained.