search

Khady / merlin-eldoc

Type and doc on hover for OCaml and Reason in emacs
GNU General Public License v3.0
43 stars 3 forks source link

Do not display type if underlying state is error #17

Closed loxs closed 6 years ago

loxs commented 6 years ago

Hi, I have been using the package with Spacemacs and while I am delighted with how useful it is, it conflicts with the functionality which is on by default in spacemacs, which is to display errors on hover.

I am not at all familiar with emacs scripting, so hopefully this is not a very stupid suggestion, but is it possible to not display the type if the state under cursor is an error, but instead let spacemacs display the error message?

Or perhaps it's reasonable to display error at cursor in merlin-eldoc itself?

Khady commented 6 years ago

This is actually not specific to spacemacs. merlin automatically calls merlin-show-error-on-current-line after an idle of 0.5s. I don't think the error should be displayed by merlin-eldoc.

Do you know if spacemacs is relying on merlin-show-error-on-current-line or something else?

Khady commented 6 years ago

@loxs please let me know if 1b1c756 fixes the problem in spacemacs.

loxs commented 6 years ago

I don't know what it calls, but your latest version now works perfectly for me. Thanks!

Khady commented 6 years ago

Thanks for the report.