search

Khady / merlin-eldoc

Type and doc on hover for OCaml and Reason in emacs
GNU General Public License v3.0
43 stars 3 forks source link

Don't error when no type is available #26

Closed Wilfred closed 6 years ago

Wilfred commented 6 years ago

merlin-eldoc--raw-type can return nil, but merlin-eldoc--format-type only supports strings. This was fixed for merlin-eldoc--type in 3af7032, but the same issue existed in merlin-eldoc--verbose-type.

Khady commented 6 years ago

Thank you. I don't have a computer for the next two weeks. But will check and merge after.

On 29 Jun 2018, at 23:51, Wilfred Hughes notifications@github.com wrote:

merlin-eldoc--raw-type can return nil, but merlin-eldoc--format-type only supports strings. This was fixed for merlin-eldoc--type in 3af7032, but the same issue existed in merlin-eldoc--verbose-type.

You can view, comment on, or merge this pull request online at:

https://github.com/Khady/merlin-eldoc/pull/26

Commit Summary

Don't error when no type is available File Changes

M merlin-eldoc.el (2) Patch Links:

https://github.com/Khady/merlin-eldoc/pull/26.patch https://github.com/Khady/merlin-eldoc/pull/26.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Khady commented 6 years ago

Actually I have access to github so I can do the merge now. Thanks!

Wilfred commented 6 years ago

Thank you :)