Broken highlighting for let

[bbatsov]

I guess it should either do nothing or highlight the matching in. (which is what happens if you go the to the in itself)

[Khady]

the highlighting of let when you are on the in is probably related to a different mode related to parenthesis or pairs

[bbatsov]

Hmm, how can that be? This doesn't happen when "highlight occurrences" from this package is disabled.

[bbatsov]

Btw, as a general point - I don't think that highlighting occurrences really belongs here, as that has little to do with eldoc.

[Khady]

This is very surprising to me, I didn't expect merlin to return occurrences when the point is on in.

I'm not against moving the highlighting of occurrences in a different mode. But

• I'm not using emacs much nowadays as most of my work has to be done on a remote server, so I'm not actively developing this mode anymore
• I not sure I want to rebuild by hand the whole logic behind eldoc-documentation-function to trigger a function after some idle time (even tho that's what this project did before https://github.com/Khady/merlin-eldoc/commit/a11e06a6c9018562a7179b5f197ff9200d67a8f6)
• having it as part of the eldoc process has the benefit of creating consistency, the highlighting and the type displayed are always related and in sync, there's no need to worry about 2 modes showing 2 different things

If you wish to work on that or other improvements to the mode I'm happy to review them and I'm open to add you as a collaborator on the repo.

[bbatsov]

Let's see how much time I'll have for OSS work this year. :-) Given that soon we'll have tree-sitter support in Emacs it will probably be best to just rely on it for things like occurrences, etc. (and would mean that such functionality can be moved to modes like tuareg) There's also going to be some LSP support built-in, which might reduce the need to use merlin directly. There are lots of interesting possibilities on the horizon.