search

Khady / ocaml-argon2

Ocaml bindings to Argon2
MIT License
29 stars 8 forks source link

Link argon2 using pkg-config #7

Closed ozanmakes closed 3 years ago

ozanmakes commented 3 years ago

With this change argon2 will be linked using pkg-config, fixing #6. Configurator docs, example from docs. I did it slightly differently to the Configurator pkg-config example and used (flags ...) instead of (c_library_flags ...) stanza since these bindings are built directly with Ctypes.Foreign and libffi instead of C stubs.

Khady commented 3 years ago

looks good, thanks. Btw I used libffi instead of c stubs because I was lazy to setup the build system, but I have nothing against it

ozanmakes commented 3 years ago

I don't think I'll have time to convert these bindings to use Cstubs these weeks, but can take a stab at it sometime.

hannesm commented 1 year ago

Some time later, I wonder whether a release could be done with this change in? :) Thanks a lot.

Khady commented 1 year ago

I'll have a look at that

hannesm commented 11 months ago

Dear @Khady, any news on this 3 months later? Would cutting a new release be possible?

Khady commented 10 months ago

trying to publish in https://github.com/ocaml/opam-repository/pull/24314

Khady commented 5 months ago

I don't really have time to investigate this build issue. It is visible in the CI too https://github.com/Khady/ocaml-argon2/actions/runs/7752494989/job/21142095865