search

Khaleelur-Rahman / pe

0 stars 0 forks source link

Missing caller for `NameContainsKeywordPredicate` and `FindCommand` in DG for sequence diagram of `find` mechanism #12

Open Khaleelur-Rahman opened 9 months ago

Khaleelur-Rahman commented 9 months ago

image.png

image.png

As the images above depict, the caller is missing for both the classes.

nus-se-bot commented 9 months ago

Team's Response

The caller of the objects are the ones where the arrow is drawn from. For example, in this case, NameContainsKeywordPredicate and FindCommand is being called from FindCommandParser.

Additionally, if you refer to not mentioning the call which calls the instance of objects, in this case, it is optional as we do not have any method calling the object of the 2 classes but instead are instantiating it through these arrows. All constructors are left out from the sequence diagrams in our DG for better comprehensibility. We have kept it consistent throughout our entire DG.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]