Khaleelur-Rahman / pe

0 stars 0 forks source link

Unspecific error message for out of range index #4

Open Khaleelur-Rahman opened 9 months ago

Khaleelur-Rahman commented 9 months ago

Steps to reproduce:

1) Type 'select 1' 2) Type 'delete 8' when the size of the students list is 7. 3) Displayed error messag is The student index provided is invalid

The error message displayed is too unspecific and does not state the reason for invalidity. Perhaps can let the user know that the index should be a positive integer >0 and <8.

nus-se-script commented 9 months ago

Team's Response

We assumed that an invalid index would be sufficient information to the user, but we recognise that implementing a more specific error message would be beneficial.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The error message The student index provided is invalid is insufficient as the user might not know the valid range for the him/her to enter. If the list is too long, this would cause the user to scroll all the way to the bottom to check the range. Another case where the mentioned error message might pop up is if the index entered is not an integer or an integer <0. A better and more specific error message would definitely be more helpful.

Quoting the website Specificity of error message: Error messages can be correct but not specific enough (e.g., it says the input is 'invalid' without giving the reason, or gives too many possible reasons without pointing out the specific reason). These cases can be considered type.FeatureFlaw.