Khaleelur-Rahman / pe

0 stars 0 forks source link

Names with a `.` are unaccepted #5

Open Khaleelur-Rahman opened 9 months ago

Khaleelur-Rahman commented 9 months ago

When a name with a . such as A.J. John is added to a course, an error message is displayed Name must begin with a letter, and can only contain alphabet and these special characters (- / ' ,).

Names with . do exist and it would be better to handle them as well.

soc-se-bot commented 9 months ago

Team's Response

Our team did not intend for abbreviated names to be included in the student list as we wanted for a student's official full name to be recorded. However, we recognise that implementing abbreviations would be beneficial to the user at no detriment to our application's functionality.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The . is not intended to represent an abbreviated name, rather it is part of some legal names. Some common examples include St. John and any names with initials at the front can be accompanied with a fullstop.

I feel that this case is analogous to the case of inclusion of / in names listed in the course website. Quoting the website : For example, disallowing s/o in a person name because / is used as a command delimiter can cause a major problem if the input is expected to match the legal name of the person.

Given that the team has mentioned in the comments that full name has to be recorded and there are plenty of Non-Singaporean students in NUS, this case should be considered in order to prevent frustration among users.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Given that the team has mentioned in the comments that full name has to be recorded and there are plenty of Non-Singaporean students in NUS, this case should be considered in order to prevent frustration among users and hence should be considered as `severity.medium`.