search

KhalidLam / CubeMail

CubeMail is a webmail client built using React and Chakra UI, It runs in the browser and uses the Gmail's public Javascript API.
https://khalidlam.github.io/CubeMail/
MIT License
38 stars 12 forks source link

How to Go to Next page ? How to retrieve next 20 Emails also what about attachments? #2

Open dhruv850 opened 4 years ago

dhruv850 commented 4 years ago

I think that is not issue but I am currently working on that I hope you can help me out there.

KhalidLam commented 4 years ago

Yes i would love to help you, this was just a side-project to learn React, but i'm planing to add more features in the future

You can send another messages.list request to get the next 20 emails but you should add pageToken to request parameters {167B2DAB-3CF1-4D57-B381-1D8FE7250241} png

I've no idea how to add attachments right now 😁

dhruv850 commented 4 years ago

Hey KhalidLam/CubeMail ,

I Tried to do this but somehow I am not able to do so. If you can please show me I would really appreciate it, and I really love your work.

Thanks in advance

Dhruv Patel

On Mon, Jul 6, 2020, 8:33 PM Lamsadi khalid notifications@github.com wrote:

Yes i would love to help you, this was just a side-project to learn React, but i'm planing to add more features in the future

You can send another messages.list request to get the next 20 emails but you should add pageToken to request parameters [image: {167B2DAB-3CF1-4D57-B381-1D8FE7250241} png] https://user-images.githubusercontent.com/17090194/86675626-bb61e500-bff1-11ea-9693-05a595e18a99.jpg

I've no idea how to add attachments right now 😁

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-654530918, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4KQNRJWEY4UPCL7PN3R2JUMLANCNFSM4OSBU4RQ .

KhalidLam commented 4 years ago

Okay I will submit new commit with function to get next page emails just to show you how, but it's just a temporary code😃

dhruv850 commented 4 years ago

Thanks man , much appreciated. Let me know when you have done that.

Dhruv Patel

On Mon, Jul 6, 2020, 9:07 PM Lamsadi khalid notifications@github.com wrote:

Okay I will submit new commit with function to get next page emails just to show you how, but it's just a temporary code😃

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-654539731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4NDGL5X7RXFK2AQA4TR2JYMZANCNFSM4OSBU4RQ .

KhalidLam commented 4 years ago

Its already done 😁 check commits and let me know if you need help

dhruv850 commented 4 years ago

Hey I Have seen the commits, but still it is not loading more emails when I scroll down. Are you able to load more Emails?

On Mon, Jul 6, 2020 at 9:15 PM Lamsadi khalid notifications@github.com wrote:

Its already done 😁 check commits and let me know if you need help

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-654542000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4NTY3MXSKSVR7ULEBTR2JZJ5ANCNFSM4OSBU4RQ .

dhruv850 commented 4 years ago

I see what your added function do is it loads another 20 Emails but it is not loading more after that. I am Just beginner into React and Node but I look forward to include fully functional application including attachments and everything. The function should be called recursively, let me know if you are updating the code again. Thanks.

On Mon, Jul 6, 2020 at 9:27 PM Dhruv Patel dhruv850.dp@gmail.com wrote:

Hey I Have seen the commits, but still it is not loading more emails when I scroll down. Are you able to load more Emails?

On Mon, Jul 6, 2020 at 9:15 PM Lamsadi khalid notifications@github.com wrote:

Its already done 😁 check commits and let me know if you need help

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-654542000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4NTY3MXSKSVR7ULEBTR2JZJ5ANCNFSM4OSBU4RQ .

KhalidLam commented 4 years ago

No, I didn't display the new emails, the function only send a request to get new emails and display it in console, I'm planning to add an Infinite scroll if you want to display the new emails too you should uncomment this line in getNextPageMessages method // setMessages((messages) => [...messages, response.result]); I'll fix this issue in the next few days don't worry 👌

dhruv850 commented 4 years ago

Yes I managed to get next 20 emails by uncommenting this line , but I was talking about infinite scroll until the end. As I have told you before I am complete learner to this but I have found a great repo from github which can help you. I am sharing you the link for it, It also have methods for displaying attachments and even downloading it. I am sharing you link https://github.com/kolya-t/Gmail-client . navigate to "Actions" and "Message Methods" for this part. This repo also has Infinite loop section but it is using redux so I don't have more idea. But it can help you really. I appreciate your help I am too working on this two parts. Please see the shared repo.

On Mon, Jul 6, 2020 at 9:48 PM Lamsadi khalid notifications@github.com wrote:

No, I didn't display the new emails, the function only send a request to get new emails and display it in console, I'm planning to add an Infinite scroll if you want to display the new emails too you should uncomment this line in getNextPageMessages method // setMessages((messages) => [...messages, response.result]); I'll fix this issue in the next few days don't worry 👌

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-654550509, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4PKZKHQTZQDWIC36ADR2J5F3ANCNFSM4OSBU4RQ .

dhruv850 commented 4 years ago

Have you got any success ?

dhruv850 commented 4 years ago

Hey KhalidLam/CubeMail Have you got any success with that ? How to get infinite scrolling ?

On Mon, Jul 6, 2020 at 9:55 PM Dhruv Patel dhruv850.dp@gmail.com wrote:

Yes I managed to get next 20 emails by uncommenting this line , but I was talking about infinite scroll until the end. As I have told you before I am complete learner to this but I have found a great repo from github which can help you. I am sharing you the link for it, It also have methods for displaying attachments and even downloading it. I am sharing you link https://github.com/kolya-t/Gmail-client . navigate to "Actions" and "Message Methods" for this part. This repo also has Infinite loop section but it is using redux so I don't have more idea. But it can help you really. I appreciate your help I am too working on this two parts. Please see the shared repo.

On Mon, Jul 6, 2020 at 9:48 PM Lamsadi khalid notifications@github.com wrote:

No, I didn't display the new emails, the function only send a request to get new emails and display it in console, I'm planning to add an Infinite scroll if you want to display the new emails too you should uncomment this line in getNextPageMessages method // setMessages((messages) => [...messages, response.result]); I'll fix this issue in the next few days don't worry 👌

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-654550509, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4PKZKHQTZQDWIC36ADR2J5F3ANCNFSM4OSBU4RQ .

dhruv850 commented 4 years ago

[image: image.png]

I was trying to get the attachments. somehow I am not able to implement it. I really needs to finish this project XD.

On Wed, Jul 8, 2020 at 12:22 PM Dhruv Patel dhruv850.dp@gmail.com wrote:

Hey KhalidLam/CubeMail Have you got any success with that ? How to get infinite scrolling ?

On Mon, Jul 6, 2020 at 9:55 PM Dhruv Patel dhruv850.dp@gmail.com wrote:

Yes I managed to get next 20 emails by uncommenting this line , but I was talking about infinite scroll until the end. As I have told you before I am complete learner to this but I have found a great repo from github which can help you. I am sharing you the link for it, It also have methods for displaying attachments and even downloading it. I am sharing you link https://github.com/kolya-t/Gmail-client . navigate to "Actions" and "Message Methods" for this part. This repo also has Infinite loop section but it is using redux so I don't have more idea. But it can help you really. I appreciate your help I am too working on this two parts. Please see the shared repo.

On Mon, Jul 6, 2020 at 9:48 PM Lamsadi khalid notifications@github.com wrote:

No, I didn't display the new emails, the function only send a request to get new emails and display it in console, I'm planning to add an Infinite scroll if you want to display the new emails too you should uncomment this line in getNextPageMessages method // setMessages((messages) => [...messages, response.result]); I'll fix this issue in the next few days don't worry 👌

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-654550509, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4PKZKHQTZQDWIC36ADR2J5F3ANCNFSM4OSBU4RQ .

KhalidLam commented 4 years ago

I'm working on other projects at the time so I cant implement it right now 😢

dhruv850 commented 4 years ago

Come on man , It will be a piece of cake for you. Hoping for your help.

On Wed, Jul 8, 2020 at 7:56 PM Lamsadi khalid notifications@github.com wrote:

I'm working on other projects at the time so I cant implement it right now 😢

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-655816970, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4NXJF7CLXQFRJRHDQLR2UBUDANCNFSM4OSBU4RQ .

dhruv850 commented 4 years ago

I have done the attachment part. Now I am able to get and download the attachments.

Now I will work on send email with attachments.

Dhruv Patel

On Wed, Jul 8, 2020, 8:00 PM Dhruv Patel dhruv850.dp@gmail.com wrote:

Come on man , It will be a piece of cake for you. Hoping for your help.

On Wed, Jul 8, 2020 at 7:56 PM Lamsadi khalid notifications@github.com wrote:

I'm working on other projects at the time so I cant implement it right now 😢

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-655816970, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4NXJF7CLXQFRJRHDQLR2UBUDANCNFSM4OSBU4RQ .

KhalidLam commented 4 years ago

Nice work, I'm working now on the infinite scrolling I'll let you know when it's done

dhruv850 commented 4 years ago

Hey , I have also implemented search functionality there, I have also implemented reply with attachments and forward with adding the attachments.

Dhruv Patel

On Sun, Jul 19, 2020, 4:07 PM Lamsadi khalid notifications@github.com wrote:

Nice work, I'm working now on the infinite scrolling I'll let you know when it's done

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-660700845, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4PIE4KF7B7QCZESY23R4NHBNANCNFSM4OSBU4RQ .

KhalidLam commented 4 years ago

Did you push the code on your Github account?
I want to see the code, or you can make a pull request if you want

dhruv850 commented 4 years ago

Hey KhalidLam/CubeMail, I was not able to make pull request I think due to permission error. But for you I have added my code to https://github.com/dhruv850/Gmail-Client-React this repository.

  1. Send email with attachments and get email with attachments including downloading it working correctly
  2. Added function to search the mail works correctly
  3. Reply to email work correctly
  4. To forward email I am able to pass the message but we need to manually add the attachments. When we forward the email it does not forward attachments it self but we can manually add it
  5. I have added load more button but there is room for improvement there.

let me know if you have any questions, and I totally thank you for creating the base.

On Sun, Jul 19, 2020 at 5:02 PM Lamsadi khalid notifications@github.com wrote:

Did you push the code on your Github account? I want to see the code, or you can make a pull request if you want

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalidLam/CubeMail/issues/2#issuecomment-660709001, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHE4T4IC3X7YU3SCQZ6M2QDR4NNNVANCNFSM4OSBU4RQ .