Changes API url to be compatible with v2

KhalisFoundation / banidb

💎 JavaScript API wrapper for BaniDB REST API

4 stars 4 forks source link

Closed Gauravjeetsingh closed 5 years ago

Gauravjeetsingh commented 5 years ago

@bogas04 @navdeepsinghkhalsa Can you please take a look into this? I checked the API URLs from the routes files of banidb-api

bogas04 commented 5 years ago

This would be a breaking change as the responses would be different. We need to make a major version bump for this.

Gauravjeetsingh commented 5 years ago

@bogas04 So, should I just change the version in package.json? :wink: Are there any other changes we want to do before doing a version bump?

bogas04 commented 5 years ago

Yes just bump the version, I or @navdeepsinghkhalsa can publish it. If you share your npm handle i can add you as a collaborator there as well.

Gauravjeetsingh commented 5 years ago

@bogas04 ji updated the version. let me know when you publish it. cc: @navdeepsinghkhalsa

Gauravjeetsingh commented 5 years ago

My npmjs handle is : turbanpanda

bogas04 commented 5 years ago

Please update package-lock as well for version. Use npm version 1.2.0

Gauravjeetsingh commented 5 years ago

@bogas04 Done

bogas04 commented 5 years ago

I've published the same.