Minor Enhancements - Githubissues

KhalisFoundation / sttm-desktop

The SikhiToTheMax Desktop App

Open Software License 3.0

34 stars 33 forks source link

Minor Enhancements #1845

Closed Gauravjeetsingh closed 10 months ago

Gauravjeetsingh commented 10 months ago

Fixes issue #1155

Hide the next/prev icon in Sundar gutka bani or ceremony

Fixes issue #1566

Make the highlighted text stand out

Fixes issue #1317

Add fade transition in viewer when changing verse (screen recorder didn't catch the smooth effect, its more smoother in actual)

saintsoldierx commented 10 months ago

In regards to the highlighting - I would leave the background transparent unless you can add some left and right padding to each word about 5px. Another option would be is to highlight those words by changing color of the font to some sort of yellow?

saintsoldierx commented 10 months ago

Can the fade transition be crossfade rather than blanking to white and fading in every time?

Gauravjeetsingh commented 10 months ago

@saintsoldierx veerji, removed the background color from highlighted words.

Crossfade won't be possible with current setup, because the viewer only has the active verse, which is changed on clicking. We would have to redo that logic to have both previous and active verse in component for crossfade to work.

Gauravjeetsingh commented 10 months ago

Merging this for alpha release, will fix the fade animation as discussed on slack in a separate PR