search

KhalisFoundation / sttm-desktop

The SikhiToTheMax Desktop App
Open Software License 3.0
34 stars 33 forks source link

Add SHARE Trademark info in About us popup #189

Closed prebhdevsingh closed 5 years ago

prebhdevsingh commented 6 years ago

Trademark SHARE Charity, UK

image

ManjotS commented 6 years ago

this should go further and include @saintsoldierx suggestions.

image

Copyright text should match web.

Then lets add: Special thanks to volunteer developers from around the globe, including: Navdeep Singh Khalsa, Inderpreet Singh, Divjot Singh, Taranjit Singh, Ishmeet Singh, Harkeerat Singh, Harpreet Singh, Irvanjit Singh, Manraj Singh, Tarsem Singh

ManjotS commented 6 years ago

Also lets add the link to privacy policy and TOS on website.

tarunsingh5 commented 6 years ago

@inderpreetsingh can you do this asap?

tarunsingh5 commented 6 years ago

@prebhdevsingh any progress here? if not - @ManjotS can you take this on? lets close these simple tickets out

maneetpaul commented 6 years ago

Copyright © 2018 Khalis Foundation , SikhiToTheMax Trademark SHARE Charity, UK

Special thanks to volunteer developers from around the globe, including: Navdeep Singh Khalsa, Inderpreet Singh, Divjot Singh, Taranjit Singh, Ishmeet Singh, Harkeerat Singh, Harpreet Singh, Irvanjit Singh, Manraj Singh, Tarsem Singh

tsingh777 commented 6 years ago

^ Balwinder Kaur.

tsingh777 commented 6 years ago

There seems to be a limit on how long the copyright can be. At the moment this window is generated by electron-builder and not much options seem to be available (https://www.electron.build/configuration/configuration#configuration). opened https://github.com/KhalisFoundation/sttm-desktop/pull/275 that adds the extended copyright.

need to investigate further on adding the special thanks and other links. https://www.npmjs.com/package/about-window seems promising if others want to take a look.

tarunsingh5 commented 6 years ago

this is probably good enough for now

tsingh777 commented 6 years ago

We can either repurpose this to add the special thanks or open a new issue for that.

tarunsingh5 commented 6 years ago

closing issue since share is now mentioned in 4.1

ManjotS commented 6 years ago

I want to leave it open for a future redesign. Ive been playing with it.

maneetpaul commented 5 years ago

In order to avoid confusion with work that was already done, I am going to close this. @ManjotS feel free to open a new issue to track any future changes.