search

KhalisFoundation / sttm-desktop

The SikhiToTheMax Desktop App
Open Software License 3.0
34 stars 33 forks source link

Support all different searches on desktop all #22

Closed tarunsingh5 closed 6 years ago

tarunsingh5 commented 6 years ago

Match all words Match any words begins with

All of the above are missing from desktop app. I don't have the desktop app but just going with what I could see on sttm website.

inderpreetsingh commented 6 years ago

Looking at sttm website and app now, 2 searches missing are

inderpreetsingh commented 6 years ago

While adding Romanized Gurmukhi , should we do phonetic search?

bickyb commented 6 years ago

Gur Fateh! Has this feature been implemented in the desktop app? I couldnit tell from the comments.

bickyb commented 6 years ago

So I just checked out the web site version and I see a problem with the romanized search feature. It does not let you search by first letter. So say for example you want to search for the shabad Jo Mange Thakur Apne Thay. You would need to know the exact spelling of the romanized shabad to be able to find it. What would be more effective is if we can search for the first letters: jmtat . This is the functionality that was available in sikhitothemax the original . Also, we need the ability to search phonetically. So say for example I am searching for the shabad Kar Kirpa Prabh Dheen Dhayala. Then I should be able to search for either ‘KKPDD’ or ‘CCPTT’ as these are phonetically close in English. This was doable in the original sikhitothemax. Please let me know if you have any questions and I can walk you through the needed functionality on a phone call if needed.

ManjotS commented 6 years ago

@bickyb we are testing the new romanized search here: http://dev.sikhitothemax.org/

We will port it to desktop if it looks good on web.

bickyb commented 6 years ago

Manjot, I just tried out the feature on the dev site but I can't seem to get it to work. When I use the 'Romanized Gurmukhi' I even try to spell out 'jo mange' and I am prompted with a 'Match the requested format' popup.
Does this just mean it is not ready for testing?
Also, will you have a different option for 'Romanized Gurmukhi first letter'?

inderpreetsingh commented 6 years ago

You need to enter at-least four words to test this feature.

On Fri, May 18, 2018 at 2:58 AM bickyb notifications@github.com wrote:

Manjot, I just tried out the feature on the dev site but I can't seem to get it to work. When I use the 'Romanized Gurmukhi' I even try to spell out 'jo mange' and I am prompted with a 'Match the requested format' popup. Does this just mean it is not ready for testing? Also, will you have a different option for 'Romanized Gurmukhi first letter'?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sttm-desktop/issues/22#issuecomment-390017804, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFEWsMvi3Dwi6OTda5PGbfKLdyCrYGWks5tzetjgaJpZM4RcvCK .

-- Inder Singh

Ekoangkaar sahai http://www.ishwerdas.com singhs.ishwer@gmail.com indrplus@gmail.com

bickyb commented 6 years ago

Awesome. I just tried it out. Will let you know how it goes.
Is the plan to also have a 'Romanized Gurmukhi first letter' search?

ManjotS commented 6 years ago

What’s in production is actually romanized first letter (we throw out the rest of the word) which is why its so bad previously.

Since we have that data, yes we can create romanized first letter. Can you create tickets in both repos for it please?

On Thu, May 17, 2018 at 2:35 PM, bickyb notifications@github.com wrote:

Awesome. I just tried it out. Will let you know how it goes. Is the plan to also have a 'Romanized Gurmukhi first letter' search?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sttm-desktop/issues/22#issuecomment-390019965, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFTI34MgJNGXet2OIhoOHdCTqy7xqks5tze0JgaJpZM4RcvCK .

tarunsingh5 commented 6 years ago

closing - let me know if this is not correct @ManjotS

ManjotS commented 6 years ago

We don't have main letter search

On Wed, Jul 4, 2018, 1:40 PM Tarun Singh notifications@github.com wrote:

closing - let me know if this is not correct @ManjotS https://github.com/ManjotS

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sttm-desktop/issues/22#issuecomment-402556100, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFU4vnqCMkRk4Ml3vlEqiGsPJ4KLhks5uDSgkgaJpZM4RcvCK .