KhalisFoundation / sttm-desktop

The SikhiToTheMax Desktop App
Open Software License 3.0
34 stars 33 forks source link

Chupai Sahib Missing Translations #267

Closed maneetpaul closed 6 years ago

maneetpaul commented 6 years ago

Towards the second half of Chupai sahib when using the desktop app, multiple slides are missing english translations

screen shot 2018-08-16 at 5 13 50 pm

tsingh777 commented 6 years ago

I think this is because the line does not have the translation in the DB. The second line has the translation. for example starting from here:


ਦੁਸ਼ਟ ਜਿਤੇ ਉਠਵਤ ਉਤਪਾਤਾ ॥
dhushaT jite auttavat autapaataa ||

ਸਕਲ ਮਲੇਛ ਕਰੋ ਰਣ ਘਾਤਾ ॥੩੯੬॥
sakal malechh karo ran ghaataa ||396||
All the villains creations outrage and all the infidels be destroyed in the battlefield.396.

The first line doesn't have translation but the line after it does and I believe it's translating both lines.

@ManjotS Can probably comment on where the translation comes from and why it's stored this way.

the example you have is like that on web as well: https://www.sikhitothemax.org/sundar-gutka/9 image

maneetpaul commented 6 years ago

@ManjotS @tarunsingh5 should this be addressed as a DB issue instead?

ManjotS commented 6 years ago

This should be a banidb issue and added to CP. its probably a good idea to just do @channel in the banidb slack and ask a sevadar to take it on for the whole bani.

On Fri, Aug 17, 2018 at 5:51 AM maneetpaul notifications@github.com wrote:

@ManjotS https://github.com/ManjotS @tarunsingh5 https://github.com/tarunsingh5 should this be addressed as a DB issue instead?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sttm-desktop/issues/267#issuecomment-413855619, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFb9hRjfIUmzLtgoAJloGJI_C33Reks5uRrxvgaJpZM4WAmKU .

maneetpaul commented 6 years ago

This is being addressed in banidb. Closing.