Plz add option to change color of gurbani and bg color

[navdeepsinghkhalsa]

@SukhmanpreetSingh This is a great suggestion, Singh Jee. It is currently planned and we are tracking it in a private JIRA instance, but we may be moving those issues to GH for the sake of transparency.

[sukhpalsingh]

I am thinking to have a 'Custom Theme' Option after the 'Dark Theme' in the settings. Once the user enable this option option, then show the controls for changing the background and font colors.

This way they can go back to the Dark / Light theme and then easily can switch to custom whenever they want.

[navdeepsinghkhalsa]

Absolutely. The custom options will be saved when toggling back between themes

[sukhpalsingh]

For the colors, are we going to use preset color classes e.g. heading-color-red, heading-color-blue etc. or we provide ability to pick the color from the color picker.

I am more inclined to use the present color classes as it make it easier to set the boundary of the available colors that can be changed and make it easier for the user to find the right color more quickly.

[navdeepsinghkhalsa]

That's a good idea. Perhaps we can do both: presets and picker. I imagine that some users may desire to match colours with their "brand" like at a Gurdwara Sahib. What do you think?

[sukhpalsingh]

Looks good. i will start working on this.

[tarunsingh5]

Sukhpal Singh Ji - wanted to check if you made any progress on this

[sukhpalsingh]

I am working on this at the moment. I am trying to find a js library which we can use to pick the colors.

[tarunsingh5]

@sukhpalsingh I'm not a dev by any means but is this package usable? http://jscolor.com/

[sukhpalsingh]

it looks good. i also found another one https://bgrins.github.io/spectrum/ which i think is good to use as it is easy to manage.

[tarunsingh5]

i like it! - let's implement it :)

[tarunsingh5]

@sukhpalsingh any luck?

[sukhpalsingh]

working on it today. thanks

[tarunsingh5]

@sukhpalsingh any update here? can @inderpreetsingh help you with this?

[sukhpalsingh]

i have added jquery based color picker and i am being told to remove jquery which is a dependency for the color picker library. I order to proceed further, i will need to do research for library without jquery and can be install through npm and need to re-factor all to remove jquery calls. I will do in the following week if possible.

[navdeepsinghkhalsa]

I apologize for the lack of feedback on this, @sukhpalsingh. Your hard work is much appreciated. What do you think about jscolor.com? @tarunsingh5 mentioned it above as well

[sukhpalsingh]

Looks good but does not have npm install so i will include from the source i guess.

[tarunsingh5]

any update on this? @inderpreetsingh can you help maybe?

[sukhpalsingh]

happy if @inderpreetsingh take this one. sorry that i could not apply the fix in last week because of busy scheudle.

[inderpreetsingh]

Got this one! Started working on it

[sukhpalsingh]

i have redone all the changes in new branches as belows: https://github.com/sukhpalsingh/sttm-core/commit/1ef4ef325f00ef83cc75a5ea5f7fd5f4c21a3dfd https://github.com/sukhpalsingh/sttm-desktop/commits/feature/6-custom-theme-with-color-picker (last two commits)

You can use the changes as it is has color picker implementation done already. Only missing bit left is apply the color from preference to the custom theme classes. i.e. gurbani, teeka etc. I could not figure this out as we are using object for the display instead of html for the slide view now.