search

KhalisFoundation / sttm-web

STTM website - https://www.sikhitothemax.org
https://www.sikhitothemax.org
Open Software License 3.0
50 stars 34 forks source link

add related shabads to angs #1154

Open ManjotS opened 4 years ago

ManjotS commented 4 years ago

in ang/page view, show all related shabads for the ang..

we could add an endpoint in sttm api to support this better so theres not 5 calls to the api

gurjit03 commented 4 years ago

@ManjotS veerji, is the API support ready?

ManjotS commented 4 years ago

not for my second sentence

ManjotS commented 4 years ago

https://github.com/KhalisFoundation/sttm-api/pull/38

tarunsingh5 commented 3 years ago

i would deprioritize this given that the scores are based on shabads not angs

tarunsingh5 commented 3 years ago

@saintsoldierx thoughts? - i think we should move this ticket to the api to actually run the algo on angs before we implement

saintsoldierx commented 3 years ago

I am not really for this tbh. I think if someone is searching by ANG then they aren't really searching for any topic in particular so why would we need related shabads? I am not sure this is a valid use case, but am open to opinion @tarunsingh5 @ManjotS @plug-n-play @tsingh777

saintsoldierx commented 2 months ago

@gurjit03 if the api work is done, then it should be easy to add this to ang view?

gurjit03 commented 2 months ago

@saintsoldierx this should be easy indeed but will check the interface. @ManjotS can you please share what API request we needs to make.