Open irvanjitsingh opened 6 years ago
Thankfully the codebase uses constant strings.
Implementation should allow ANY language
Punjabi, hindi, italian, french, spanish and german should be priorities imo
Yeah we'll add full i18n support. However baani translations/transliteration wouldn't support that.
On Fri, Apr 13, 2018, 9:36 PM Manjot Singh notifications@github.com wrote:
Implementation should allow ANY language
Punjabi, hindi, italian, french, spanish and german should be priorities imo
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/SikhiToTheMax-Web/issues/413#issuecomment-381183628, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5DVVU7KVx-ccwxNnBiK3iS77WOo93-ks5toM0CgaJpZM4TSv51 .
--
Regards, Divjot Singh https://bogas04.github.io/.
@saintsoldierx how do you think we should implement language option? Header? Footer?
🌐 English 🔽
Click
🌐 English 🔼
Punjabi
@bogas04 can it detect which country user is in and default to their local language?
In terms of options, it should be a flag icon in top right which expands to show different country flags and names.
where is strings file so i can get translation service to work on it
On Sun, May 6, 2018 at 1:39 PM, saintsoldierx notifications@github.com wrote:
@bogas04 https://github.com/bogas04 can it detect which country user is in and default to their local language?
In terms of options, it should be a flag icon in top right which expands to show different country flags and names.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/SikhiToTheMax-Web/issues/413#issuecomment-386911522, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFYwbjPpdq5Kpjb_WaTGK2ECSajHIks5tv1-bgaJpZM4TSv51 .
Right now it's in constants file
On Mon, May 7, 2018, 4:41 AM Manjot Singh notifications@github.com wrote:
where is strings file so i can get translation service to work on it
On Sun, May 6, 2018 at 1:39 PM, saintsoldierx notifications@github.com wrote:
@bogas04 https://github.com/bogas04 can it detect which country user is in and default to their local language?
In terms of options, it should be a flag icon in top right which expands to show different country flags and names.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/KhalisFoundation/SikhiToTheMax-Web/issues/413#issuecomment-386911522 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAnXFYwbjPpdq5Kpjb_WaTGK2ECSajHIks5tv1-bgaJpZM4TSv51
.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/SikhiToTheMax-Web/issues/413#issuecomment-386924072, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5DVSXfEilxONcEgo04W-GqHrheuvFdks5tv4M4gaJpZM4TSv51 .
--
Regards, Divjot Singh https://bogas04.github.io/.
We need the following done:
separate all strings to a file and use something like react-localization (used in other apps)
In settings, add ability to change language from the default language chosen by react-localization.
If India is the detected country or hindi the detected language (or pakistan and urdhu), pop up asking which indic language: hindi or punjabi (use local strings for each button), or same for pak/urdhu. This shouldn't happen again if there is a cookie/saved setting.
If the detected language is gurmukhi/punjabi, just use that, same as any other language.
Make sure the india popup is forward-compatible in the sense we can add other languages like gujrati, urdhu etc.
@saintsoldierx please prioritize
@ManjotS i believe we waiting on you for some translations for this? Please update issue.
Where are we at with this @ManjotS ?
@gurjit03 can you please help firstly to make sure all strings are in a local file?
Self-explanatory. The only search app that implements this is Isher Micro Media on mobile devices.