KhalisFoundation / sttm-web

STTM website - https://www.sikhitothemax.org
https://www.sikhitothemax.org
Open Software License 3.0
50 stars 36 forks source link

do not auto search with searchtype drop down change #441

Closed ManjotS closed 6 years ago

ManjotS commented 6 years ago

What went wrong ?

when I am searching, search type drop down changes auto search. This is usually undesired.

What should have happened instead ?

To reduce error exposure, we shouldn't auto search unless the search input was first changed. Otherwise we are adding more load to the api for no reason (ie searching first letter search 123).

How can authors of this project cause the issue to occur on their systems ?

  1. search for ang 123
  2. change drop down to first letter search
  3. error
bogas04 commented 6 years ago

This was a requested feature: https://github.com/KhalisFoundation/SikhiToTheMax-Web/issues/143