search

KhalisFoundation / sttm-web

STTM website - https://www.sikhitothemax.org
https://www.sikhitothemax.org
Open Software License 3.0
50 stars 34 forks source link

Ability to disable cartoonified 404 pages #466

Closed taranjs closed 1 year ago

taranjs commented 6 years ago

While the cool cartoons on 404 pages are awesome, they might not be the best experience when presenting to loads of live sangat in the Gurdwara Sahib.

Eg. this page https://www.sikhitothemax.org/search?q=random

The user should have ability to turn them off because it is very common to have typo and land on these pages, which could be distracting for the sangat.

plug-n-play commented 6 years ago

@ManjotS @saintsoldierx @bogas04 @navdeepsinghkhalsa @taranjs - shall we remove this altogether or still keep it with an option to disable it inside settings?

ManjotS commented 6 years ago

we want to keep it. We are discussing options, but for now can consider removing from results page. We are thinking to add more characters.

We can make an option to turn it off everywhere for sure.

On Fri, May 18, 2018 at 12:37 PM, plug-n-play notifications@github.com wrote:

@ManjotS https://github.com/ManjotS @saintsoldierx https://github.com/saintsoldierx @bogas04 https://github.com/bogas04 @navdeepsinghkhalsa https://github.com/navdeepsinghkhalsa @taranjs https://github.com/taranjs - shall we remove this altogether or still keep it with setting option?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/SikhiToTheMax-Web/issues/466#issuecomment-390311191, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFWSCY0CNf5kgv7nGmkS0JgJdDjkmks5tzyMLgaJpZM4UE3fM .

saintsoldierx commented 6 years ago

The cartoons are a little quirky - but i like them. They just need improving.

gurjit03 commented 1 year ago

@saintsoldierx so should I completely disable (remove) from all the search pages ?

saintsoldierx commented 1 year ago

@gurjit03 for now, can you add an option in the settings to turn it off/on? Default should be off for now.

gurjit03 commented 1 year ago

@saintsoldierx with settings I presume you are saying about sidebar menu options, though that means it will be available as an option per user/browser tab not universally controllable.

saintsoldierx commented 1 year ago

@gurjit03 i am fine with it being per browser tab... but if we have SSO working, can we not make this as part of a profile preference?