KhalisFoundation / sttm-web

STTM website - https://www.sikhitothemax.org
https://www.sikhitothemax.org
Open Software License 3.0
50 stars 36 forks source link

Full Word Translation (English) search should search by whole word #742

Closed tejbirsingh closed 4 years ago

tejbirsingh commented 5 years ago

When I search with Full Word Translation (English), I would expect to see matches of that whole word.

Searching hem returns every result that includes them or any other word that has the string hem. I think it should only return results with the whole word itself.

image

I believe Full Word implies whole word matching, so I would expect results like this: image

To Reproduce Version: web Select Full Word Translation (English) from the drop down search a word that can be a part of other words (hem, man, all etc.)

If this was a conscious choice, please ignore this.

bogas04 commented 5 years ago

@ManjotS @tarunsingh5

saintsoldierx commented 5 years ago

Is this a BaniDB API issue @ManjotS @tarunsingh5

ManjotS commented 5 years ago

No, this is a feature.

For this FR we would need to implement a single word only search on api and then maybe have a checkbox on site that switches to it "Full word only" and also if its in quotes.

Or we could just advise use quotes and implement that within all existing search types. Please make api ticket.

On Fri, Oct 18, 2019 at 8:22 PM Aman Singh notifications@github.com wrote:

Is this a BaniDB API issue @ManjotS https://github.com/ManjotS @tarunsingh5 https://github.com/tarunsingh5

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sttm-web/issues/742?email_source=notifications&email_token=AAE5OFLHWL7Z7WJYORNMCPDQPIEHFA5CNFSM4IHHKUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBVTXKY#issuecomment-543898539, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE5OFP3TKX3LGSJCZ5ZEZTQPIEHFANCNFSM4IHHKUNA .

saintsoldierx commented 4 years ago

hem should bring up all results like them. "hem" should only bring up results with hem, not them. Similar to how to Google works. Multiple words "their feet" should bring up results with those words in exact order. their feet should bring up results with those words anywhere in the results.

ManjotS commented 4 years ago

Aman, this is an API issue, not a web issue. I would classify quotes under operators. So this seems to already be fixed in Raj's branch.

On Sun, Jun 7, 2020 at 5:20 PM Aman Singh notifications@github.com wrote:

hem should bring up all results like them. "hem" should only bring up results with hem, not them. Similar to how to Google works. Multiple words "their feet" should bring up results with those words in exact order. their feet should bring up results with those words anywhere in the results.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sttm-web/issues/742#issuecomment-640302271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE5OFKTBXVX2XYHXWG6XHDRVQVFPANCNFSM4IHHKUNA .

saintsoldierx commented 4 years ago

Can I close this then @ManjotS ?

ManjotS commented 4 years ago

Yes. If it doesn't work as you expect, please open API tickets for specific bugs (check dev first)