KhalisFoundation / sttm-web

STTM website - https://www.sikhitothemax.org
https://www.sikhitothemax.org
Open Software License 3.0
50 stars 34 forks source link

auto substitute (as option) letters in first letter/main letter search #878

Open ManjotS opened 6 years ago

ManjotS commented 6 years ago

all the pair bindis should be found with normal letters

ManjotS commented 6 years ago

open oora with normal

ManjotS commented 6 years ago

@tarunsingh5 can you create a mapping of this for me?

ie ਸ => ਸ਼

ManjotS commented 6 years ago

but in ascii not unicode

tarunsingh5 commented 6 years ago

should this be done in the api or should this be done in the app? for example w/ khakha we did this in the app

ManjotS commented 6 years ago

this should have been done in the api

On Tue, Mar 13, 2018 at 3:00 PM, Tarun Singh notifications@github.com wrote:

should this be done in the api or should this be done in the app? for example w/ khakha we did this in the app

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/BaniDB-API/issues/23#issuecomment-372833557, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFYxMZt8DlIz0cIl8ZQkhiw4IUZgOks5teEGGgaJpZM4Re-VI .

tarunsingh5 commented 6 years ago

so i actually think it should be done in the app b/c the user should have the option to use the fuzzy mapping or not and we should keep the api as explicit as possible

@navdeepsinghkhalsa thoughts?

ManjotS commented 6 years ago

agree @tarunsingh5 (lets add the fuzzy ticket to sttm-web and close this)

saintsoldierx commented 3 years ago

This one is high priority - I have to type in pairi KHAKHA to get KHALSA MERO ROOP HAI KHAAS. A regular KHAKHA should also find this. Same for other bindhi characters. image

ManjotS commented 3 years ago

The substitution itself should be part of anvaad, so web can just include anvaad. It may have already been implemented. Good question for irvanjit singh.

irvanjitsingh commented 3 years ago

There's a few optional flags for this implemented in the firstLetter and mainLetter functions. Documented on the anvaad readme @ManjotS @saintsoldierx

saintsoldierx commented 3 years ago

Would love it if we can get this one done too @gsin11

https://github.com/KhalisFoundation/anvaad-js for the readme

saintsoldierx commented 3 years ago

For this, we would want those pehar bindhi akhars to show only if searching in Gurmukhi and only is searching full words. Not first letter. The other thing is if someone types any of those characters with a pehar bindhi, such as ਸ then it should also seatch ਸ਼. Goes for all 5 letters.

irvanjitsingh commented 2 years ago

@saintsoldierx if that's the intended usecase, then firstLetter/mainLetter columns should be regenerated with the 'simplify' flag enabled in anvaad. this will replace all ਸ਼ with ਸ, etc. Since full word search doesn't use the firstLetter or mainLetter columns, it would be unaffected and searching for ਸ would give ਸ and ਸ਼ would give ਸ਼. Also, note that regenerating firstLetter's with the flag is only one part, the query string would also require the same logic to be applied to replace characters. This can be added in anvaad as well or implemented in sttm.

saintsoldierx commented 1 year ago

@ManjotS something you can take up? If this can be done using simplify flag, then let's do it at Anvaad level?

gurjit03 commented 2 months ago

@ManjotS @saintsoldierx We wants to continue with this ?

saintsoldierx commented 2 months ago

@ManjotS @saintsoldierx We wants to continue with this ?

Yes, it's been outstanding for a while