search

KhalisFoundation / sundar-gutka-react

Other
10 stars 7 forks source link

fix: firebase push notification #101

Closed amitojsingh closed 2 years ago

amitojsingh commented 2 years ago

This PR updates the firebase push notification feature which was outdated earlier

inderpreetsingh commented 2 years ago

@amitojsingh veerji, you probably missed some of the requested changes above. Also, this branch started getting conflicts. Please resolve them as well.

amitojsingh commented 2 years ago

@inderpreetsingh veer ji I think I have fixed all could you please check again.

inderpreetsingh commented 2 years ago

@inderpreetsingh veer ji I think I have fixed all could you please check again.

veerji please try clicking Load more... text there are 7 hidden conversations that requires your attention. image

amitojsingh commented 2 years ago

Apologies, I missed that.

inderpreetsingh commented 2 years ago

Apologies, I missed that.

No worries veerji. Great job :raised_hands: Let's resolve the last comment and get this one merged.

inderpreetsingh commented 2 years ago

This one can be merged @amitojsingh veerji