search

KhalisFoundation / sundar-gutka-react

Other
10 stars 8 forks source link

add setting to change default font colors #18

Open ManjotS opened 6 years ago

ManjotS commented 6 years ago

under colors section, offer changing all the colors header1, header2, bishram, larivaar etc etc

offer a reset button for colors too (separate from global reset)

kee23 commented 6 years ago

Do we want themes or a color picker? If it is a picker, then I'm assuming it overrides current font colors, regardless of light/dark theme unless we want to separate them out. Also, assuming this will change for reader view only (not list/bookmarks/settings/about).

ManjotS commented 6 years ago

list/bookmark/reader

i think custom color picker is what people asked for.. themes are nicer though.. ie low contrast and high contrast themes

On Fri, Jul 27, 2018 at 5:21 PM kee23 notifications@github.com wrote:

Do we want themes or a color picker? If it is a picker, then I'm assuming it overrides current font colors, regardless of light/dark theme unless we want to separate them out. Also, assuming this will change for reader view only (not list/bookmarks/settings/about).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sundar-gutka-react/issues/18#issuecomment-408568292, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFa3q5Q1IMiQbTqmq4_YXBzjqDtH0ks5uK655gaJpZM4VkyRd .

kee23 commented 6 years ago

I figured it would be pick colors for:

We could add larivaar colors too. And if it's list/bookmarks, then call it menu color? The danger in adding settings if they pick a color that blends with the background, then they can't see anymore.

ManjotS commented 6 years ago

Yeah don't add settings. Sounds good.

On Fri, Jul 27, 2018, 9:01 PM kee23 notifications@github.com wrote:

I figured it would be pick colors for:

  • Gurmukhi
  • Transliteration
  • Translation

We could add larivaar colors too. And if it's list/bookmarks, then call it menu color? The danger in adding settings if they pick a color that blends with the background, then they can't see anymore.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sundar-gutka-react/issues/18#issuecomment-408580684, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFdVJbb6mSCfHMUJwORnbbyUPlnK0ks5uK-IFgaJpZM4VkyRd .