search

KhalisFoundation / sundar-gutka-react

Other
11 stars 9 forks source link

Pinch to Change font size #35

Open tarunsingh5 opened 5 years ago

tarunsingh5 commented 5 years ago

pinch to zoom effect but it should change the font size and not just zoom in

kee23 commented 5 years ago

Alright I'm thinking along with this we are including a new custom font size option in settings where users can just input a number through a text field. Otherwise we would be shifting through the existing font size options which would make pinch to zoom less smooth.

ManjotS commented 5 years ago

Slider is better.

On Fri, Feb 8, 2019, 8:36 PM kee23 <notifications@github.com wrote:

Alright I'm thinking along with this we are including a new custom font size option in settings where users can just input a number through a text field. Otherwise we would be shifting through the existing font size options which would make pinch to zoom less smooth.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sundar-gutka-react/issues/35#issuecomment-462012883, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFeau_xSUNeSyGwAR3Fe8mx9n6Bt8ks5vLlBfgaJpZM4ax6Wx .

kee23 commented 5 years ago

Yo other feedback I heard was be able to adjust font sizes separately for gurmukhi, transliteration, etc. Reason being those who use translit like it for some parts, but want to skip at others. However this might conflict with this feature.