search

KhalisFoundation / sundar-gutka-react

Other
10 stars 8 forks source link

change settings toggle colors #8

Closed ManjotS closed 5 years ago

ManjotS commented 6 years ago

from green to sundar gutka blue

tarunsingh5 commented 6 years ago

is this still an issue @ManjotS

ManjotS commented 6 years ago

yes

On Fri, May 25, 2018 at 8:05 AM, Tarun Singh notifications@github.com wrote:

is this still an issue @ManjotS https://github.com/ManjotS

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/sundar-gutka-react/issues/8#issuecomment-392086983, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFYKoFKGm3R0bQlWr7QdyU_2UFgIwks5t2B2igaJpZM4Tp6qq .

akaldesign commented 6 years ago

I had some trouble finding the appropriate variable to change in the react-native-settings-list library that is currently being used for the Settings page. This suggests that the library doesn't support it yet.

However, react native delivered components DO support this task (https://github.com/facebook/react-native/pull/11940). Knowing this we can wait until the library that is being used gets updated OR change the implementation to use React Native delivered components.

tarunsingh5 commented 5 years ago

can i close this issue @kee23 @ManjotS

ManjotS commented 5 years ago

no. i still hate the colors

tarunsingh5 commented 5 years ago

fixed in 5.3

ManjotS commented 5 years ago

not fixed

tarunsingh5 commented 5 years ago

@kee23 said it is fixed, i think you two need to discuss further

tarunsingh5 commented 5 years ago

this was fixed in 5.3