search

Khan / aphrodite

Framework-agnostic CSS-in-JS with support for server-side rendering, browser prefixing, and minimum CSS generation
5.35k stars 188 forks source link

Bump up inline-style-prefixer version #358

Closed cyejia closed 5 years ago

cyejia commented 5 years ago

This PR bumps the version of inline-style-prefixer up to 5.0.4 so that Aphrodite has the css logical plugin.

The imports in inline-style-prefixer changed from versions 4 to 5, so this PR also updates some of the import paths, and removes the compatibility: true option in generateData, which determined whether the plugin data generated used ES5 or ES2015 imports.

khanbot commented 5 years ago

Hey @chenyejia,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly, khanbot

cyejia commented 5 years ago

[clabot:check]

khanbot commented 5 years ago

CLA signature looks good :+1:

somewhatabstract commented 5 years ago

Does the loss of compatibility setting have any implications for Aphrodite usage after this lands?

lencioni commented 5 years ago

@somewhatabstract it looks like the compatibility flag only swaps between require or import for inline-style-prefixer plugins. More info in this PR: https://github.com/Khan/aphrodite/pull/361#issue-254044665

https://github.com/rofrischmann/inline-style-prefixer/blob/608ac33bd65d6732915745e74521b6475e1916d8/modules/generator/index.js#L5-L10

Since the require statement it generates does not use .default, the compatibility option breaks the aphrodite build.

TL;DR: I don't think this has any implications for Aphrodite usage after this lands.

lencioni commented 5 years ago

@chenyejia thanks for the PR!