search

Khan / aphrodite

Framework-agnostic CSS-in-JS with support for server-side rendering, browser prefixing, and minimum CSS generation
5.35k stars 188 forks source link

Make parameter typings for StyleSheet.create more typed #375

Closed BenjaVR closed 5 years ago

BenjaVR commented 5 years ago

This is a small change in the typings, to make the StyleSheet.create(...) parameters more typed, and offer better intellisense/autocompletion.

before:

screencast_before

after:

screencast_after

The only thing I couldn't figure out is how to get the intellisense for pseudo selectors inside a mediaquery. Although you can use it without any errors, it's just the intellisense that is not complete. Anyone any ideas?

khanbot commented 5 years ago

Hey @BenjaVR,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly, khanbot

BenjaVR commented 5 years ago

[clabot:check]

khanbot commented 5 years ago

CLA signature looks good :+1: