search

Khan / aphrodite

Framework-agnostic CSS-in-JS with support for server-side rendering, browser prefixing, and minimum CSS generation
5.35k stars 188 forks source link

Fix the build: Upgrade inline-style-prefixer and typescript versions #396

Closed Brianzchen closed 3 years ago

Brianzchen commented 3 years ago

This dependency has to be updated before future changes can be made. Without this change, the build is broken and doesn't work because caniuse-api removed the ie_mob browser.

Related docs https://github.com/robinweser/inline-style-prefixer/blob/master/CHANGELOG.md#600

typescript tests breaking as a result of typescript version being too low. Updated to 3.2.0 as per recommendations

Related issue https://github.com/DefinitelyTyped/DefinitelyTyped/issues/47250

@jlfwong @lencioni

khanbot commented 3 years ago

Hey @Brianzchen,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly, khanbot

Brianzchen commented 3 years ago

[clabot:check]

khanbot commented 3 years ago

CLA signature looks good :+1:

Brianzchen commented 3 years ago

@lencioni build breaking because of TS tests. I'm not familiar with that area, any ideas on what we could do?

Brianzchen commented 3 years ago

Looks like last build fails, not sure why yet

Screen Shot 2020-12-17 at 1 10 06 pm
jlfwong commented 3 years ago

I just skimmed the change, so I'm merging this on the strength of @lencioni's approving