search

Khan / engblog

KA Engineering blog.
http://engineering.khanacademy.org
Other
29 stars 20 forks source link

Sams post #35

Closed SamLau95 closed 8 years ago

SamLau95 commented 8 years ago

@brownhead Hey! I don't have write access to KA repos anymore so I made a PR from my own fork. This has William's commit too for the upcoming post. We'll merge this in on Aug. 31.

wchargin commented 8 years ago

Builds fine for me.

wchargin commented 8 years ago

@brownhead Any idea why the checks are consistently failing?

sophiebits commented 8 years ago

I think this will fail on any pull request since Travis won't provide the key:

https://github.com/Khan/engblog/blob/5350c96d7690388366756e627b3537ab3973ba36/.travis.yml#L7

You can do something like this to check:

https://github.com/facebook/react/blob/f641f29db0a16edfeb8ec666e1db51abbdc6f1a8/.travis.yml#L22

itsjohncs commented 8 years ago

Awesome! I'll pull this in around lunch time today, unless you'd like me to pull it in sooner/later @SamLau95.

I opened up an issue (#36) to take care of the incorrectly failing build. Sorry it was giving everyone trouble :(.

wchargin commented 8 years ago

no trouble @brownhead!