search

Khan / engblog

KA Engineering blog.
http://engineering.khanacademy.org
Other
29 stars 20 forks source link

Add a blog post about my internship on the XOM initiative #63

Closed shadaj closed 7 years ago

shadaj commented 7 years ago

Summary: This is a blog post about the projects I worked on and technologies I used during my internship on the web frontend team.

Test Plan: Run make serve and verify that sidebar has new blog post and blog content is properly shown

shadaj commented 7 years ago

Thanks for the comments! They should be fixed now. Let me know if you have any more suggestions!

latteier commented 7 years ago

Great blog post! @kevinbarabash asked me to look it over, so I added a few small comments of things that I think could be improved, but otherwise, it looks great.

shadaj commented 7 years ago

Thanks for the comments! I addressed the feedback in the latest commit.

kevinbarabash commented 7 years ago

@shadaj thanks for updating. A few minor tweaks and we should be good to go. I'll leave some comments tomorrow when I have some more time.

shadaj commented 7 years ago

Thanks for the additional feedback! I addressed it in the latest commit.

kevinbarabash commented 7 years ago

@shadaj thanks so much! I'll do a final check over the weekend, but I think we should be able to get this out for Monday.

kevinbarabash commented 7 years ago

LGTM. I'll do the merge on Monday so that the post goes out then.

shadaj commented 7 years ago

Awesome! I've updated the post publish date to be Monday.

kevinbarabash commented 7 years ago

@shadaj thanks for updating the publish date. Sorry for deploying so late. Do you want to share this on HN?

kevinbarabash commented 7 years ago

https://news.ycombinator.com/item?id=13166755