search

Khan / engblog

KA Engineering blog.
http://engineering.khanacademy.org
Other
29 stars 20 forks source link

Remove wsgiref as a dependency (for Python 3 compatibility) #70

Closed sloria closed 6 years ago

sloria commented 6 years ago

Summary: wsgiref is Python 2-only, so it causes make deps to fail when using a Python 3 virtualenv.

After removing it, make deps and make serve commands still work as expected.

csilvers commented 6 years ago

Unfortunately the person who added this is no longer at Khan Academy, so I can't ask them directly, but: do you know what wsgiref was added as a dep to begin with? I'm hesitant to remove a dep that I don't understand it's purpose. It's possible it's for some make command besides serve.

csilvers commented 6 years ago

Ah wait, I think I see what the issue is: wsgiref has been part of the standard library since python2.5. Presumably this dep was added before then. So removing this just causes us to start using the standard wsgiref instead.

I don't even see any mentions of wsgiref in code, so presumably this is needed by one of the other deps.)