search

Khan / engblog

KA Engineering blog.
http://engineering.khanacademy.org
Other
29 stars 20 forks source link

Make body and title sizes more responsive #73

Closed sloria closed 6 years ago

sloria commented 6 years ago

Improves legibility on desktop-size screens by

  1. Increasing the base font size from 14px to 16px
  2. Increasing the contrast between title and body text

Implements the following:

Desktop (Before)

Desktop (Before)

Desktop (After)

Desktop (After)

Note: Ignore the underline under the logo: I was hovering over it when I took the screenshot 😺

Mobile (Before)

Mobile (Before)

Mobile (After)

Mobile (After)

Partially addresses #68

sloria commented 6 years ago

Travis build is failing due to installation issues on master and lint issues addressed in #72, but make phantomjs-tests passes locally.

csilvers commented 6 years ago

OK, @brownhead never wrote back. I'm just going to go with it!