search

Khan / engblog

KA Engineering blog.
http://engineering.khanacademy.org
Other
29 stars 20 forks source link

npm audit fix security vulnerabilities #78

Closed drosile closed 5 years ago

drosile commented 5 years ago

Automated fixes from npm audit fix

drosile commented 5 years ago

i think the travisci integration is broken. it says iv undefined -- it might be missing secrets or something.

dangoor commented 5 years ago

Unfortunately, broken travis also means no builds of the blog itself

csilvers commented 5 years ago

Did you test that we can still rebuild the blog after the update? I'd love to have at least some cursory checks this upgrade doesn't break anything.

drosile commented 5 years ago

ah, yes, i should have mentioned. i did make deps & make serve after these changes and it looked fine to me