search

Khan / genqlient

a truly type-safe Go GraphQL client
MIT License
1.08k stars 109 forks source link

Image in README is hard to read in GitHub's dark/dimmed mode #17

Closed kevinbarabash closed 3 years ago

kevinbarabash commented 3 years ago
Screen Shot 2021-04-21 at 9 43 41 PM Screen Shot 2021-04-21 at 9 42 36 PM
benjaminjkraft commented 3 years ago

Hah, good point! I guess I could do a white background, but that seems like it might be annoying too. Or I could use some color. Other ideas welcome.

benjaminjkraft commented 3 years ago

See also https://github.community/t/support-theme-context-for-images-in-light-vs-dark-mode/147981.

kevinbarabash commented 3 years ago

SVG does support media queries so I think we could probably build an asset that reverses itself based on the browser settings. If someone has their GitHub preferences to always use dark mode regardless of the browser setting it won't handle that case.

benjaminjkraft commented 3 years ago

Oh, interesting, good point! I had switched from SVG to PNG so I didn't have to worry about fonts, but there are obviously other ways of handling that. I'll take a look when I get a chance.

benjaminjkraft commented 3 years ago

@kevinbarabash your solution worked! Subject to the caveat you gave, which I think is better than the alternatives.