We were smart about aliasing if you have name-collisions, but not if your package name is something that's not a valid identifier, like "path/to/my-package", which Go for better or worse allows. Now we remove all the invalid characters (in practice mainly dashes, dots, and leading digits).
Fixes #231.
Test plan: make check
I have:
[x] Written a clear PR title and description (above)
We were smart about aliasing if you have name-collisions, but not if your package name is something that's not a valid identifier, like
"path/to/my-package", which Go for better or worse allows. Now we remove all the invalid characters (in practice mainly dashes, dots, and leading digits).Fixes #231.
Test plan: make check
I have: