Subscription support - Githubissues

Khan / genqlient

a truly type-safe Go GraphQL client

MIT License

1.07k stars 107 forks source link

Subscription support #294

Closed matthieu4294967296moineau closed 1 month ago

matthieu4294967296moineau commented 1 year ago

Added support for graphQL subscriptions.

Using graphql.NewClientUsingWebSocket(), the returned graphql.WebSocketClient will be able to subscribe to graphQL endpoints.
Implementation does not depend on a specific websocket package, but it is similar to github.com/gorilla/websocket (this package is also used to create a client in the tests).

I have:

[x] Written a clear PR title and description (above)
[x] Signed the Khan Academy CLA
[x] Added tests covering my changes, if applicable
[x] Included a link to the issue fixed, if applicable
[x] Included documentation, for new features
[x] Added an entry to the changelog

StevenACoffman commented 1 year ago

Hi! In addition to your CEO, you also need to sign the CLA as yourself, since you are the one contributing the code. Thanks!

matthieu4294967296moineau commented 1 year ago

Hi! In addition to your CEO, you also need to sign the CLA as yourself, since you are the one contributing the code. Thanks!

Done !

matthieu4294967296moineau commented 12 months ago

According to your comments, I modified the code so that it is now possible to have several subscriptions using the same webSocket connection. There is also now only 1 go routine that runs to listen the webSocket messages instead of 2 before. I also made the minor changes listed in the previous comments.

HaraldNordgren commented 5 months ago

@matthieu4294967296moineau Any updates here? It would be great to have this available! 🤗

its-a-feature commented 4 months ago

Any progress here? This seems super cool and I love the functionality so far, but I need subscriptions to be possible before I can fully use it :(

weidonglian commented 4 months ago

Any progress on this? @matthieu4294967296moineau Thanks for your contribution and effort on this.

benjaminjkraft commented 1 month ago

Great! Thanks for the fixes and sorry for the delay! I did the merging, it looks like I can't push to your branch (not sure if that's a permission issue on my end or yours but oh well) but I'll just stick it in a new PR and merge that way.

benjaminjkraft commented 1 month ago

Merged via #347! Thanks so much!