Support more valid graphql file extensions

zzh8829 commented 4 months ago

There are two other commonly used graphql file extension we should support .gql - used by apollo and other client library to differentiate query from schema .graphqls - used by gqlgen and other server library to differentiate schema from query

https://github.com/apollographql/apollo-tooling/blob/a778ca162bdd20be9e60a914887302390c274644/packages/apollo/src/commands/client/download-schema.ts#L19

I have:

[x] Written a clear PR title and description (above)
[x] Signed the Khan Academy CLA
[x] Added tests covering my changes, if applicable
[x] Included a link to the issue fixed, if applicable
[x] Included documentation, for new features
[x] Added an entry to the changelog

benjaminjkraft commented 4 months ago

This looks good to me! We can merge once I get confirmation from the CLA person on CLAs and get a chance to look slightly closer at the lint issue (I doubt it's related)

benjaminjkraft commented 4 months ago

CLA confirmed. Lint is fixed on main, but either I don't have permission to merge into your branch or I don't know how to use that permission from CLI, so I think you'll need to do that. Once you do we should be good!

zzh8829 commented 4 months ago

rebased

Khan / genqlient

Support more valid graphql file extensions #309