Pin lint workflow's Go version - Githubissues

Khan / genqlient

a truly type-safe Go GraphQL client

MIT License

1.02k stars 99 forks source link

Pin lint workflow's Go version #311

Closed benjaminjkraft closed 4 months ago

benjaminjkraft commented 4 months ago

We weren't pinning the Go version for golangci-lint (only the golangci-lint version); seemingly it breaks on 1.21+. Now we're using a new version making it easy to pin back to 1.20. Later I'll look at why 1.21+ are failing (#313).

While I was at it I added tests on 1.21 (1.22+ is failing, again will look later, #312), and upgraded the setup-go action itself.

I have:

[x] Written a clear PR title and description (above)
[x] Signed the Khan Academy CLA
[x] Added tests covering my changes, if applicable (n/a)
[x] Included a link to the issue fixed, if applicable (n/a)
[x] Included documentation, for new features (n/a)
[x] Added an entry to the changelog (n/a)

benjaminjkraft commented 4 months ago

merging before review since it's blocking some PRs and it's pretty safe, but lmk if there are any concerns and I'll follow up later!