Upgrade golangci-lint and which go we run it with - Githubissues

Khan / genqlient

a truly type-safe Go GraphQL client

MIT License

1.02k stars 99 forks source link

Upgrade golangci-lint and which go we run it with #314

Closed benjaminjkraft closed 4 months ago

benjaminjkraft commented 4 months ago

Apparently our version of golangci-lint didn't work with Go 1.21+ on our codebase. A newer version does, which required redoing the depguard config (I think it's equivalent to what we had) and one tweak for the benefit of gocritic.

Fixes #313.

I have:

[x] Written a clear PR title and description (above)
[x] Signed the Khan Academy CLA
[x] Added tests covering my changes, if applicable (n/a)
[x] Included a link to the issue fixed, if applicable
[x] Included documentation, for new features (n/a)
[x] Added an entry to the changelog (n/a)