Khan / khan-exercises

A (deprecated) framework for building exercises to work with Khan Academy.
http://www.khanacademy.org/
1.61k stars 863 forks source link

Graphing inequalities 2 without choosing an answer #161538

Closed wrwrwr closed 8 years ago

wrwrwr commented 8 years ago

With a bit of zoom the point choice below the graph is not visible, thus it's easy to click through leaving the default "Yes" selected (be it right or wrong).

Removing the default checked state and making the validator function return an empty string when it should seems to be a good start. The exercise still gets marked wrong though, so I guess the empty string return is not functional at the moment. Further, it would be nice to be able to show an orange frame surrounding the choices if the user does not select anything.

itsjohncs commented 8 years ago

Thank you for poking at this! Unfortunately I don't think this is ready to merge in yet since it doesn't fix the issue you're seeing, but if you're able to figure out how to get KE to say "invalid answer" (I'm not sure how to do that personally) or otherwise resolve the issue I'll be happy to merge this in.

I'm going to close this, but definitely open up another PR if/when you're able to finish this up.