search

Khan / khan-exercises

A (deprecated) framework for building exercises to work with Khan Academy.
http://www.khanacademy.org/
1.61k stars 863 forks source link

Don't always assume double arrows in graphInit() #161572

Closed danielhollas closed 4 years ago

danielhollas commented 4 years ago

Summary: This if statement would always evaluate as true, which I'm pretty sure isn't what we want, though who knows what's out there that depends on this behavior :\

Test Plan:

  1. Substate this into graphie-to-png
  2. Run app.py in graphie-to-png
  3. Go to http://localhost:5001/ and choose "1. Simple plot"
  4. Change the axisArrows: "<->" line to "->" and "" and regraph, seeing the correct axis arrows

Reviewers: aria, emily

Reviewed By: emily

Differential Revision: https://phabricator.khanacademy.org/D15861

(cherry picked from commit c992ca8ba0ec895da32d1db9c795f9cf6686a568)

danielhollas commented 4 years ago

This is just a cherry-pick from the master branch, see discussion in: https://khanacademy.atlassian.net/browse/IC-443

The Travis build fails while installing Ruby gems, dunno what to do about that. Seems like the test for the latest commit to graphie-to-png branch failed as well a week ago, so... :man_shrugging: