search

Khan / khan-exercises

A (deprecated) framework for building exercises to work with Khan Academy.
http://www.khanacademy.org/
1.62k stars 864 forks source link

Autolabeling bugs from localized versions of the site with their subdomain would probably be a good idea #82260

Closed theinternetftw closed 11 years ago

theinternetftw commented 11 years ago

Is it cool if I work on that? Is that wanted?

sophiebits commented 11 years ago

Yeah, though I'm not sure if there's a limit on the number of labels so you may want to add it in the title or just in the body of the issue (in the sandcastle link, if not more prominently).

sophiebits commented 11 years ago

(KA.language contains the language code on the live site; I don't remember about locally.)

theinternetftw commented 11 years ago

Some moderate searching didn't find it. Would you like me to wait for that to be added here (if that would even make sense), or just go ahead with subdomain-foo?

One thing I just checked about the labels is that I think you have create them on the repo (give them a name and a color) before use, either through the website or the API. Probably better off just putting it in the title or body.

theinternetftw commented 11 years ago

Actually, it looks like I can rely on icu.getLocale(), which relieves me, as khanacademy.org silently accepts any improper subdomain.

sophiebits commented 11 years ago

Okay. It's probably not totally necessary to even worry about language locally since no one reports issues from sandcastle anyway.

theinternetftw commented 11 years ago

https://github.com/Khan/khan-exercises/pull/82339 fixedit