search

Khan / khan-mobile

You’re probably looking for www.github.com/khan/mobile
237 stars 34 forks source link

No exercises -- important comments within. #135

Closed dokkaebi closed 12 years ago

dokkaebi commented 12 years ago

These changes include a commit that UNDOES adam's ada4b1392a0ccd1c4b3cb30e4d2d779ea324110b (change from mp4 to m3u8). This likely needs to go in a new Android branch instead of over no_exercises, assuming adam actually needs that change.

adamjernst commented 12 years ago

Hmm. I do need m3u8 for iPad. Then again, that could probably go on an "ios" branch instead of no_exercises.

Or could you implement behavior to use m3u8 first and then fall back on mp4?

Also, you could use canPlayType('application/vnd.apple.mpegurl; codecs="avc1.42E01E"') as a test ideally to verify that the device can play m3u8. See #134.

benkomalo commented 12 years ago

Hi Austin,

Eventually all the videos will have an m3u8 version; we're currently in the process of making that conversion. If you want other fixes in this merge other than that (which should fix itself eventually as the migration finishes - we'll let you know when), you might want to de-couple them

Ben

adamjernst commented 12 years ago

It's fine to revert the m3u8 change for now. Not all android devices support m3u8.

dokkaebi commented 12 years ago

That should work better. Let me know what you think.

adamjernst commented 12 years ago

Awesome!

adamjernst commented 12 years ago

I'm going to go ahead and merge this.