search

Khan / khan-mobile

You’re probably looking for www.github.com/khan/mobile
237 stars 34 forks source link

transcript info seems to disappear rather than scroll off the screen #41

Closed jasonrr closed 13 years ago

jasonrr commented 13 years ago

I think we need to give the transcript content something to scroll under at the top and bottom so that it's more clear what's going on.

adamjernst commented 13 years ago

Agreed.

jeresig commented 13 years ago

Yep! Just to be clear, this is a visual/UI change then, not necessarily a behavior change.

jasonrr commented 13 years ago

I've taken a crack at this. Let me know what you think.

https://github.com/Khan/khan-mobile/commit/0344891d6141e5a773b0ccc4ad35a5571033378d

jeresig commented 13 years ago

Looks good! Although I just noticed that it's not quite wide enough: http://gyazo.com/2783b8b7cda7dc37d0e53b7a2bb47c38.png

jasonrr commented 13 years ago

Where are you seeing that? It is intentionally not as wide as the container because the container includes the scrollbar.

adamjernst commented 13 years ago

Can we use a CSS repeating background image instead of an actual element? That seems the way to go...

jasonrr commented 13 years ago

A background image would be necessarily underneath the content, and wouldn't allow the text to pass beneath it. Unless I am misunderstanding your suggestion.

adamjernst commented 13 years ago

But if you placed a subelement using css position relative, with left: 0 right: 0 top:0 height: Npx, wouldn't that do it? My CSS chops are not up to snuff but I think I've done something like this before.

jasonrr commented 13 years ago

We could use a pseudo element instead of an actual element, for sure, but that's not going to affect the issue that John's describing, I don't think.

p.s. The contents of the elements is already a repeating background image, I've adjusted the width so that it doesn't appear over the scroll bar.

adamjernst commented 13 years ago

My fault; you're already doing what I had suggested. (Silly me for not checking.) So that's irrelevant.

jasonrr commented 13 years ago

@jeresig are you still seeing this problem? Can you tell me how to repro it?