search

Khan / khan-mobile

You’re probably looking for www.github.com/khan/mobile
237 stars 34 forks source link

Oauth login throws an error if iPad time is incorrect #68

Closed mwahl closed 13 years ago

mwahl commented 13 years ago

After hitting the login button:

With correct minutes time: http://imgur.com/4aDMAl&Dc1vu

Incorrect minutes time (+10M shifted): http://imgur.com/4aDMA&Dc1vul

adamjernst commented 13 years ago

Yep, clock drift happens all the time on iOS devices. We'll have to handle this correctly.

adamjernst commented 13 years ago

This is really a khan-api issue.

kamens commented 13 years ago

@adamjernst I relaxed this such that it will only affect devices off by > 72 hours. In your experience w/ iOS clock drift, do you think we will still suffer? If so, I'll just remove the check or fix more correctly.

adamjernst commented 13 years ago

iOS clock drift is usually no more than 5 minutes. I think 72 hours is plenty generous.

kamens commented 13 years ago

(Thanks, will be deployed soon.)