search

Khan / khan-windows

Khan Academy for Windows 8
31 stars 15 forks source link

Topic tree was moved around and science and ecomonics was split in 2 fixes #82

Closed bbondy closed 11 years ago

bbondy commented 11 years ago

Verified that server is returning 8, maybe something is up with the recent refactoring of the topic tree code. I'll investigate.

bbondy commented 11 years ago

Existing list we have:

id                 title x29232c6b New and Noteworthy x7a488390 Math xb92336a2 Science & Economics x905db83d Humanities x7626d097 Test Prep xd1039e22 Talks and Interviews xae887ec6 Projects & Discovery Lab

Changes on remote: 1) It looks like Science and Economics was split into i) Science (using the old id) and ii) Economics and Finance (using a new id: x5ca94af1) ***We need new image for this or re-use an existing one

2) "Partner content" is unknown to the app with ID x54390c7e (We have some CSS syles for this so I think this is old and we don't want it) ***I think no action is required.

3) "Coach resources" is unkonwn to the app with ID x6a4a5e33 ***I think no action is required.

4) "Computer programming" is unknown to the app but I think this is on purpose ***I think no action is required.

5) x7626d097 "Test Prep" and xae887ec6 "Projects & Discovery Lab" ****no longer show up, I think we need to remove these

bbondy commented 11 years ago

I verified via a web call from the browser directly and it looks like that returns both topics mentioned in comment 5, so it looks like our parser or response handling code needs fixing and isn't including all of the domains.

We do have to do something about the first point above though (1)

bbondy commented 11 years ago

x7626d097 Test Prep is inside of math now.

bbondy commented 11 years ago

xae887ec6 Projects & Discovery Lab is inside of science now.

bbondy commented 11 years ago

@anprak do you think we should allow an extra level of hierarchy? or do you want to pluck these back out to top level?

bbondy commented 11 years ago

I'm thinking we have to leave it as is outside of the top level, looks like only a minor fix is needed for the description saying "null"

anprak commented 11 years ago

Great analysis, Brian. I think the fix you have in place is good. We just need a new image for finance and economics. With two domains going inside other domains, we are ok for those as these were 3 levels before and now has become part of 4 level hierarchy which is already supported in the app.