search

Khan / khan-windows

Khan Academy for Windows 8
31 stars 15 forks source link

Exclude topics and tutorials from library with zero videos #83

Open anprak opened 11 years ago

anprak commented 11 years ago

To avoid bad user experiences.

bbondy commented 11 years ago

Looks like it does have videos, but it has 2 topic children, and under those there are videos. Do we need support for an extra level of hierarchy

bbondy commented 11 years ago

We can still fix "Exclude topics and tutorials from library with zero videos" for some other example, but for the last comment we'd post a new bug about it.

anprak commented 11 years ago

I think we should not hard code the number of levels we have the library. I thought they weren't hardcoded but seems they are.

There are different types of objects and each one is handled differently with a dedicated page in the app. Shouldn't we be able to handle at whatever level these objects are?

bbondy commented 11 years ago

I think we should not hard code the number of levels we have the library. I thought they weren't hardcoded but seems they are.

Fully agreed but right now it seems like it's just a bunch of nested for loops :(. I'll post a new bug about changing this to a recursive parsing algorithm that can support any number of levels.

bbondy commented 11 years ago

Removed image since it wasn't an example of this, but leaving this bug to handle the potential issue of 0 videos still showing the topic.