search

Khan / live-editor

A browser-based live coding environment.
Other
761 stars 185 forks source link

modal sound picker doesn't work in demo/index.html #250

Open kevinbarabash opened 9 years ago

kevinbarabash commented 9 years ago

This isn't really a bug per se because $.fn.modal exists in production. It isn't however being included as part of our build process so it may become a bug if other parts of the KA pipeline decide to replace jquery-ui's modal() with something else.

codeHusky commented 9 years ago

A TON of stuff breaks in the live editor demo. I haven't gotten to reporting most of the bugs there.

kevinbarabash commented 9 years ago

@MikaalSky could you add a couple of them to this issue? I'd like to get an idea of the general shape of these issues (if there is one). It would be nice if the demo environment and the production environment were a bit closer.

@pamelafox this got me thinking about all of the things that we include in core_deps to make the demo work that may also be included a second time to make all the stuff surround the live-editor work. My hunch is that jquery is being included twice and two different custom builds of jquery-ui. If the live-editor were a node module then the demo and any downstream projects could just require('live-editor'). Okay, it might be a bit more complicated than that. The benefit though, if the downstream projects also use "require", is duplicate dependencies should disappear and our memory use and load times should see a decrease.

kevinbarabash commented 9 years ago

@MikaalSky the issue with sound not working in the demo app will be addressed by pull request https://github.com/Khan/live-editor/pull/243.

codeHusky commented 9 years ago

So do you want me to post them on this issue?

kevinbarabash commented 9 years ago

After thinking about it a bit more it's probably best to just file them as separate issues. Maybe @pamelafox can add a "demo" tag so that we can track these issues separately. I don't want to distract from dealing with production issues, but at the same I think it's good to be aware of these issues as well.

kevinbarabash commented 9 years ago

@pamelafox thanks for the "demo" label.