search

Khan / live-editor

A browser-based live coding environment.
Other
761 stars 184 forks source link

Images/sounds not working correctly due to changing from kasandbox to kastatic urls #747

Open Steffan153 opened 3 years ago

Steffan153 commented 3 years ago

A lot of programs aren't working anymore because for some reason, KA is using kastatic.org URLs instead of kasandbox.org.

For example, a sound URL KA used to use: https://www.kasandbox.org/programming-sounds/rpg/metal-clink.mp3 What it uses now (this link is broken): https://cdn.kastatic.org/third_party/javascript-khansrc/live-editor/sounds/rpg/metal-clink.mp3

Or image URL: https://www.kasandbox.org/programming-images/animals/fox.png to https://cdn.kastatic.org/third_party/javascript-khansrc/live-editor/build/images/animals/fox.png

So that's one thing, the new sound URLs don't even work.

But for images, the image URLs work, and image()/getImage() seem to work, but then when you try to call get() after displaying an image, it errors.

MatthiasPortzel commented 3 years ago

Bumping this. All sounds are broken and using images taints the canvas with cross-site content. I don't know who at KA if anyone is in charge of fixing bugs in this repo, but it would be appreciated to give us an acknowledgement that this is a known issue. @jeresig @pamelafox

(OurJSEditor allows you to load sounds from anywhere, so it doesn't have these issues.)

pamelafox commented 3 years ago

I'm not currently working at Khan Academy, have you also filed a ticket at https://khanacademy.zendesk.com/hc/en-us/requests/new?ticket_form_id=261028 ? That typically raises the priority of issues for the engineering team.

I suggest also linking to programs that worked before and no longer work.

Steffan153 commented 3 years ago

I'll do that.

There are 100s of programs that are broken actually. I could link to some though.

MatthiasPortzel commented 3 years ago

This seems to have been rolled back a couple of days ago, and is currently working.