search

Khan / react-components

khan.github.io/react-components/
MIT License
1.01k stars 99 forks source link

First component is not much of a sell :) #11

Closed kamens closed 10 years ago

kamens commented 10 years ago

I realize it's alphabetically ordered, but reading the whole spiel at the top of the page got me all pumped and proud about our contributions at KA, but then the first component said, "You should know that I highly recommend not using this mixin."

...and it made me question the value of the page/components.

ariabuckles commented 10 years ago

Maybe we can/should just take the backbone mixin out of here if we don't recommend using it?

joelburget commented 10 years ago

Fixed by https://github.com/Khan/react-components/commit/c8bfe9fd7d8fc9fc880b1eb8482c8a5959530407

I wanted to leave it around since we still use it. Also I want it to be open source so I can use it as an example in the future.